From 60c390f9925bf3fc26241090b9e037c7da6b8b36 Mon Sep 17 00:00:00 2001 From: Valentine Wallace Date: Mon, 15 Jul 2024 15:38:37 -0400 Subject: [PATCH] Document ser for BOLT 12 pending outbound payments. Useful since these variants will be dropped on downgrade, so want some text to explain why that's okay. --- lightning/src/ln/outbound_payment.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs index aaae85b8631..a88d2da980d 100644 --- a/lightning/src/ln/outbound_payment.rs +++ b/lightning/src/ln/outbound_payment.rs @@ -2005,17 +2005,23 @@ impl_writeable_tlv_based_enum_upgradable!(PendingOutboundPayment, (1, reason, option), (2, payment_hash, required), }, + // Added in 0.0.123. Prior versions will drop these outbounds on downgrade, which is safe because + // no HTLCs are in-flight. (5, AwaitingInvoice) => { (0, expiration, required), (1, invoice_request, option), (2, retry_strategy, required), (4, max_total_routing_fee_msat, option), }, + // Added in 0.0.123. Prior versions will drop these outbounds on downgrade, which is safe because + // no HTLCs are in-flight. (7, InvoiceReceived) => { (0, payment_hash, required), (2, retry_strategy, required), (4, max_total_routing_fee_msat, option), }, + // Added in 0.0.124. Prior versions will drop these outbounds on downgrade, which is safe because + // no HTLCs are in-flight. (9, StaticInvoiceReceived) => { (0, payment_hash, required), (2, keysend_preimage, required),