Skip to content

Commit f3f4010

Browse files
committed
Wait for inbound commitment_signed before producing tx_signatures
We only want to produce `tx_signatures` once we know that the monitor update (either the initial one for a dual-funded channel, or a `RenegotiatedFunding` one for a splice) has been persisted. If we haven't received the counterparty's `commitment_signed` yet, then the monitor update hasn't been created, leading us to pass the `!awaiting_monitor_update` condition and produce a holder `tx_signatures` message.
1 parent f6e57d6 commit f3f4010

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9334,6 +9334,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
93349334
if let Some(signing_session) = (!channel.is_awaiting_monitor_update())
93359335
.then(|| ())
93369336
.and_then(|_| channel.context.interactive_tx_signing_session.as_mut())
9337+
.filter(|signing_session| signing_session.has_received_commitment_signed())
93379338
.filter(|signing_session| signing_session.holder_tx_signatures().is_none())
93389339
{
93399340
if signing_session.has_local_contribution() {

0 commit comments

Comments
 (0)