You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
close_channel_internal should fallback to force-closure if the channel is in the inbound/outbound sets, though I'm not sure its super critical,
update_partial_channel_config should probably be updated to work on any channel
internal_shutdown should FC any pending channels
do_chain_event needs to call best_block_updated even on unfunded channels so we time out channels if they aren't funded in 2 weeks
peer_connected tries to remove outbound unfunded channels on reconnect but doesn't look at the new outbound map (which, now that I look at it, should be generating a ChannelClosed event, but isn't...ugh we need to consolidate the channel close codepaths)
Rename get_funding_outbound_created to get_funding_created
The text was updated successfully, but these errors were encountered:
do_chain_event needs to call best_block_updated even on unfunded channels so we time out channels if they aren't funded in 2 weeks
It seems and I feel that the timeout is distinct in the sense that it's for established, but not yet confirmed inbound channels which seems right. (i.e. specifically waiting for funding to confirm) These are necessarily already Channels.
Question: If we've always just relied on this as a timeout for receiving a funding_created as well? I feel like that should be handled differently and probably have a shorter timeout honestly. As we're not waiting on a funding tx to confirm, we're actually waiting on our peer to just send a message.
Question: If we've always just relied on this as a timeout for receiving a funding_created as well? I feel like that should be handled differently and probably have a shorter timeout honestly. As we're not waiting on a funding tx to confirm, we're actually waiting on our peer to just send a message.
Agreed, I don't see any reason to not impose a shorter deadline then. Mostly we just want to revert back to the behavior we had previously, which is giving up after some time of still being unconfirmed, regardless of receiving funding_created or not.
I'm happy with either one - it does seem like that could totally be a shorter deadline (taking two weeks to build the funding tx at all is absurd), but also fine with going back to what it was and just doing it based on block height.
There are a bunch of followups to #2077 that need to be included before 116.
See: #2077 (review)
Reproduced below:
close_channel_internal
should fallback to force-closure if the channel is in the inbound/outbound sets, though I'm not sure its super critical,update_partial_channel_config
should probably be updated to work on any channelinternal_shutdown
should FC any pending channelsdo_chain_event
needs to callbest_block_updated
even on unfunded channels so we time out channels if they aren't funded in 2 weekspeer_connected
tries to remove outbound unfunded channels on reconnect but doesn't look at the new outbound map (which, now that I look at it, should be generating a ChannelClosed event, but isn't...ugh we need to consolidate the channel close codepaths)get_funding_outbound_created
toget_funding_created
The text was updated successfully, but these errors were encountered: