Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make on-close channel_update messages more robust #2711

Closed
TheBlueMatt opened this issue Nov 6, 2023 · 6 comments · Fixed by #2731
Closed

Make on-close channel_update messages more robust #2711

TheBlueMatt opened this issue Nov 6, 2023 · 6 comments · Fixed by #2731
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

When we force-close a channel we send an advisory channel_update to the currently connected peers to let the world know that the channel is now closed (by setting the disable bit). This doesn't do anything if we force-close on startup, because we have no peers. We should retry broadcasting these at some point in the future by caching them a bit. Other nodes currently dont do this (and absolutely should), but for now we should at least make our more reliable.

@TheBlueMatt TheBlueMatt added this to the 0.0.119 milestone Nov 6, 2023
@shaavan
Copy link
Member

shaavan commented Nov 11, 2023

Can I give this a try?

@TheBlueMatt
Copy link
Collaborator Author

Yes, feel free. Not quite sure how we should go about this, probably looking at channelmonitors on startup.

@shaavan
Copy link
Member

shaavan commented Nov 12, 2023

I've tried expanding upon a different approach!

I've been monitoring our node's ability to reach out to anyone when it's time to broadcast, whether that happens at startup or any other timer while the node is running.

If, for some reason, we miss the broadcast, we'll just give it another go and resend the pending broadcast messages.

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.119, 0.0.120 Nov 28, 2023
@TheBlueMatt
Copy link
Collaborator Author

We should still try to get this done in 119, but if it slips to 120, there's really no reason we need to delay the release for it.

@shaavan
Copy link
Member

shaavan commented Nov 29, 2023

@TheBlueMatt
A gentle ping! :)

The PR resolving this issue (#2731) is ready for review.

@TheBlueMatt
Copy link
Collaborator Author

Important, but not worth holding up a bug fix release for.

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.120 , 0.0.121 Jan 17, 2024
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.122, 0.0.123 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants