-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make on-close channel_update
messages more robust
#2711
Comments
Can I give this a try? |
Yes, feel free. Not quite sure how we should go about this, probably looking at channelmonitors on startup. |
I've tried expanding upon a different approach! I've been monitoring our node's ability to reach out to anyone when it's time to broadcast, whether that happens at startup or any other timer while the node is running. If, for some reason, we miss the broadcast, we'll just give it another go and resend the pending broadcast messages. |
We should still try to get this done in 119, but if it slips to 120, there's really no reason we need to delay the release for it. |
@TheBlueMatt The PR resolving this issue (#2731) is ready for review. |
Important, but not worth holding up a bug fix release for. |
When we force-close a channel we send an advisory
channel_update
to the currently connected peers to let the world know that the channel is now closed (by setting the disable bit). This doesn't do anything if we force-close on startup, because we have no peers. We should retry broadcasting these at some point in the future by caching them a bit. Other nodes currently dont do this (and absolutely should), but for now we should at least make our more reliable.The text was updated successfully, but these errors were encountered: