Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel::get_dust_buffer_feerate comment doesn't match code #2815

Closed
TheBlueMatt opened this issue Jan 6, 2024 · 1 comment · Fixed by #2971
Closed

Channel::get_dust_buffer_feerate comment doesn't match code #2815

TheBlueMatt opened this issue Jan 6, 2024 · 1 comment · Fixed by #2971
Milestone
0.0.123

Comments

@TheBlueMatt
Copy link
Collaborator

I think the code should be changed. Pointed out at #2808 (comment)
@TheBlueMatt TheBlueMatt mentioned this issue Jan 6, 2024
Merged
@TheBlueMatt TheBlueMatt added this to the 0.0.121 milestone Jan 16, 2024
@jbesraa
Copy link
Contributor

jbesraa commented Mar 24, 2024

I would like to work on this issue as part of the next Review Club. I will run it on Tuesday (March 26th), and by the end of the session I believe there will be an open PR.

@jbesraa jbesraa mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.123
Development

Successfully merging a pull request may close this issue.

Fix comparison in get_dust_buffer_feerate jbesraa/rust-lightning
2 participants
@TheBlueMatt @jbesraa