-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_restored_packages_retry
is brittle
#2827
Labels
good first issue
Good for newcomers
Comments
Hi there, I've solved this issue on my local repo. Just wanted to ask if I can make a PR right away or do I need to be assigned the issue? |
Feel free to open a PR! |
Harsh1s
added a commit
to Harsh1s/rust-lightning
that referenced
this issue
Jan 17, 2024
…packages_retry` fixes lightningdevkit#2827
Note that #3302 improves this a bit, even if it doesn't fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
test_restored_packages_retry
broke in #2288 and again in #2697.Per #2697 (comment), it will break every time we add a fetch for random bytes on startup.
To fix this, make the random bytes deterministic within the test using
TestKeysInterface::override_random_bytes
and regenerate the monitor by logging it in the parent commit of a3b416a#diff-6b0cbdb9c86bfc52581a89ea5c23454f692199b2192be965f34a47429b3cf912R1748, right above the linked test line.The text was updated successfully, but these errors were encountered: