Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont abandon payments based on the payment_id in an unauthenticated InvoiceError message (or any other unauthenticated msg) #3166

Closed
TheBlueMatt opened this issue Jul 10, 2024 · 3 comments · Fixed by #3192
Closed

Dont abandon payments based on the payment_id in an unauthenticated InvoiceError message (or any other unauthenticated msg) #3166

TheBlueMatt opened this issue Jul 10, 2024 · 3 comments · Fixed by #3192
Assignees
@jkczyz
Milestone
0.0.124

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Jul 10, 2024 •
edited
Loading

Filing this to make sure we get it, should be fixed in #3139.
@TheBlueMatt TheBlueMatt added this to the 0.0.124 milestone Jul 10, 2024
@jkczyz jkczyz self-assigned this Jul 10, 2024
@jkczyz
Copy link
Contributor

jkczyz commented Jul 10, 2024

Doesn't look like #3198 exists.

@TheBlueMatt
Copy link
Collaborator Author

Ugh sorry

@jkczyz
Copy link
Contributor

jkczyz commented Jul 11, 2024

We also shouldn't abandon when attempting to pay and erroring with a Bolt12PaymentError::DuplicateInvoice.

@jkczyz jkczyz mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkczyz jkczyz

Labels
None yet
Projects
None yet
Milestone
0.0.124
Development

Successfully merging a pull request may close this issue.

Authenticate InvoiceError messages jkczyz/rust-lightning
2 participants
@TheBlueMatt @jkczyz