Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Splicing] Update Splicing msgs #3293

Closed
optout21 opened this issue Sep 5, 2024 · 1 comment
Closed

[Splicing] Update Splicing msgs #3293

optout21 opened this issue Sep 5, 2024 · 1 comment

Comments

@optout21
Copy link
Contributor

optout21 commented Sep 5, 2024 •
edited
Loading

Some minor updates to the spicing messages, to reflect the spec changes (from lightning/bolts#863 to lightning/bolts#1160 )
This is in preparation for splicing ( #1621 )
Prerequisites: None

Changes can be seen in #3274 , changes to file msgs.rs.

Changes include:

  • some renames (splice -> splice_init, some field names)
  • batched commitments support (commitment_signed)
  • some new fields such as require_confirmed_inputs
@optout21 optout21 mentioned this issue Sep 5, 2024
Closed
@optout21
Copy link
Contributor Author

optout21 commented Sep 6, 2024 •
edited
Loading

My bad, this was already done with #3129 (it's both in main and in #3274, not sure why it shows there as diff ). Closing.

@optout21 optout21 closed this as completed Sep 6, 2024
@optout21 optout21 mentioned this issue Sep 12, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@optout21