Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Splicing] Add splicing compile feature flag #3294

Closed
optout21 opened this issue Sep 5, 2024 · 1 comment
Closed

[Splicing] Add splicing compile feature flag #3294

optout21 opened this issue Sep 5, 2024 · 1 comment

Comments

@optout21
Copy link
Contributor

optout21 commented Sep 5, 2024

Introduce a new splicing flag (hint: RUSTFLAGS="--cfg=splicing" ...).
The splicing flag should be independent of dual_funding (they can be used in isolation), but splicing implies the dual funding logic.
Dual funding parts should be surrounded with any(dual_funding, splicing), splicing-only with only splicing.
This is in preparation for splicing ( #1621 )
It is a rather mechanical infrastructure change but would make the future splicing PRs cleaner.

Prerequisites: #3137

Changes can be seen in #3274 , changes of the form #[cfg(...)].

@jkczyz
Copy link
Contributor

jkczyz commented Sep 12, 2024

Already added in #3001.

@jkczyz jkczyz closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants