-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building 0.0.125
on i686-linux-android
fails
#3415
Comments
Oh interesting, we do release builds on android which built fine. What version of |
Oh, I see your struct is smaller, yea, that maybe makes sense on some 32-bit platforms on newer |
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Nov 23, 2024
We expect `ChannelLiquidity` to be exactly three cache lines to ensure the first bytes we need are all one one cache line, but in practice its a bit more ideal for `ChannelLiquidity`s to always start on an even cache line as x86 CPUs will often load the neighboring cache line automatically. Further, it looks like some versions of `rustc` on some platforms don't pack `ChannelLiquidity` as well (in lightningdevkit#3415) and the next commit is going to push us over three cache lines anyway. Instead, here we calculate out the proper padding for `ChannelLiquidity` to make it align to four 64-byte cache lines. Should fix lightningdevkit#3415.
Should be fixed by #3422, at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building version
0.0.125
on 32 bit fails withMaybe the 32 bit
usize
affects theChannelLiquidity
size calculation in_LIQUIDITY_MAP_SIZING_CHECK_2
?rust-lightning/lightning/src/routing/scoring.rs
Line 805 in 8da30df
This worked fine with the previous version we used,
0.0.118
.Is this a bug, or was support for 32 bit dropped in the meantime? Thanks.
The text was updated successfully, but these errors were encountered: