Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce send_payment_with_route with the new API #3523

Open
TheBlueMatt opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3534
Open

Re-introduce send_payment_with_route with the new API #3523

TheBlueMatt opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3534
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

We removed send_payment_with_route cause the API was inscruitable and hard to work with without double-payment bugs, but that doesn't mean the concept of sending with a route isn't useful. We currently let users do that by manually matching the payment_id in their router, but that's pretty annoying to deal with, and we can do it internally. We should just do it with the new API that's practical to use rather than the old APIError-based one.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant