Handle fallible commitment secret #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
+ Coverage 89.83% 90.08% +0.25%
==========================================
Files 121 121
Lines 100612 102971 +2359
Branches 100612 102971 +2359
==========================================
+ Hits 90380 92766 +2386
- Misses 7564 7571 +7
+ Partials 2668 2634 -34 ☔ View full report in Codecov by Sentry. |
alecchendev
force-pushed
the
2024-06-async-commit-secret-raa
branch
2 times, most recently
from
cf058bc to
18acc2a
Compare
|
This needs rebase now 🎉 |
alecchendev
force-pushed
the
2024-06-async-commit-secret-raa
branch
from
18acc2a to
e296b74
Compare
|
Rebased! Btw, for the missing test coverage in #3150, I'll get to those in the PR where I handle fallible per commitment point for the channel reestablish case (as opposed to here), since I think those cases will require that - hoping to make that PR this week |
alecchendev
force-pushed
the
2024-06-async-commit-secret-raa
branch
2 times, most recently
from
50df53a to
e4ad15b
Compare
|
CI is very, very sad. |
|
Otherwise basically LGTM, nice and easy PR :) |
alecchendev
force-pushed
the
2024-06-async-commit-secret-raa
branch
from
e4ad15b to
3413032
Compare
|
lol yesterday i thought i fixed the CI error but didn't commit anything and did an empty force push 😆 |
TheBlueMatt
approved these changes
Jul 17, 2024
valentinewallace
approved these changes
Jul 17, 2024
| @@ -10,18 +10,21 @@ | |||
| //! Tests for asynchronous signing. These tests verify that the channel state machine behaves | |||
| //! properly with a signer implementation that asynchronously derives signatures. | |||
|
|
|||
| use std::collections::HashSet; | |||
There was a problem hiding this comment.
nit: in most files we have a use crate::prelude::*;, which I believe would avoid this
There was a problem hiding this comment.
Ah, right, think that means this file will fail to build no-std, though we can also fix that when we drop the cfg flag.
Comment on lines
+5535
to
+5536
| log_trace!(logger, "Last revoke-and-ack pending in channel {} for sequence {} because the next per-commitment point is not available", | ||
| &self.context.channel_id(), self.context.holder_commitment_point.transaction_number()); |
There was a problem hiding this comment.
nit: I think this log is redundant with the ones above
|
Gonna land, @alecchendev can handle the followups in #3109. |
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Jul 19, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Jul 20, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Sep 16, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Sep 16, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Sep 16, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Sep 17, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Sep 18, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Nov 26, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Nov 26, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 6, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 10, 2024
This also slightly refactors get_funding_signed_msg to match the logic more similarly, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 11, 2024
For all of our async signing logic in channel establishment v1, we set signer flags in the method where we create the raw lightning message object. To keep things consistent, this commit moves setting the signer flags to where we create funding_created, since this was being set elsewhere before. While we're doing this cleanup, this also slightly refactors our funding_signed method to move some code out of an indent, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 11, 2024
For all of our async signing logic in channel establishment v1, we set signer flags in the method where we create the raw lightning message object. To keep things consistent, this commit moves setting the signer flags to where we create funding_created, since this was being set elsewhere before. While we're doing this cleanup, this also slightly refactors our funding_signed method to move some code out of an indent, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 13, 2024
For all of our async signing logic in channel establishment v1, we set signer flags in the method where we create the raw lightning message object. To keep things consistent, this commit moves setting the signer flags to where we create funding_created, since this was being set elsewhere before. While we're doing this cleanup, this also slightly refactors our funding_signed method to move some code out of an indent, as well as removes a log to fix a nit from lightningdevkit#3152.
alecchendev
added a commit
to alecchendev/rust-lightning
that referenced
this pull request
Dec 13, 2024
For all of our async signing logic in channel establishment v1, we set signer flags in the method where we create the raw lightning message object. To keep things consistent, this commit moves setting the signer flags to where we create funding_created, since this was being set elsewhere before. While we're doing this cleanup, this also slightly refactors our funding_signed method to move some code out of an indent, as well as removes a log to fix a nit from lightningdevkit#3152.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on
#3149,#3150. Most of the logic for this was added in the prerequisite PRs. Here we just set thesigner_pending_revoke_and_ackflag if we fail to get the commitment secret.