Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSRV dependencies #3484

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Dec 12, 2024

No description provided.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for one, we already pin MSRV dependencies in ci-tests.sh, not directly in the workflow. If anything, this should be added there.

As previously discussed elsewhere, we could consider pinning rustls back for now, but I think we landed on not doing that as it invites substantial longer-term security risk to our users. So, we likely need to bump the MSRV for lightning-transaction-sync, which in turn might mean we need to move it out of our workspace for now and treat it separately again. (cc @TheBlueMatt)

Also see the related discussion topic I opened on BDK's end: bitcoindevkit/bdk#1750

@arik-so arik-so marked this pull request as draft December 12, 2024 08:24
@arik-so
Copy link
Contributor Author

arik-so commented Dec 12, 2024

Thanks! I drafted this PR for the time being pending. If we decide to move out lightning-transaction-sync it obviously doesn't apply.

@arik-so arik-so marked this pull request as ready for review December 12, 2024 18:20
@arik-so
Copy link
Contributor Author

arik-so commented Dec 12, 2024

Per our discussion, undrafting this.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline: we'll land this for now to fix CI until we move the lightning-transaction-sync out of the workspace and give it its own MSRV.

@arik-so arik-so merged commit 6e85a0d into lightningdevkit:main Dec 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants