Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for signet #111

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

mrfelton
Copy link
Contributor

@mrfelton mrfelton commented Aug 15, 2024

Is there anything more than this needed to enable signet support?

Fixes #80

@samfeder
Copy link

Bump on this. Anything else needed?

@guggero
Copy link
Member

guggero commented Aug 22, 2024

Oh, I think this fell below the radar because it looked like a duplicate of lightninglabs/faraday#193 when I looked at my daily notifications.
Sorry about that, will put it in my review queue now.

@samfeder you're welcome to test and review as well to move along faster.

@guggero guggero self-requested a review August 22, 2024 17:31
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Confirmed that the lndclient version is up to date and should handle all the lnd connection related part of signet support.

@guggero guggero requested a review from bhandras August 22, 2024 17:33
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦄

@Roasbeef Roasbeef merged commit b901c20 into lightninglabs:master Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signet support
4 participants