Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes shouldn't publish their commitment when receiving outdated channel_reestablish #6017

Open
t-bast opened this issue Nov 23, 2021 · 0 comments
Open

Nodes shouldn't publish their commitment when receiving outdated channel_reestablish #6017

t-bast opened this issue Nov 23, 2021 · 0 comments
Assignees
@Roasbeef
Labels
channel closing Related to the closing of channels cooperatively and uncooperatively channel management The management of the nodes channels spec

Comments

@t-bast
Copy link
Contributor

t-bast commented Nov 23, 2021

When receiving a channel_reestablish that indicates that your peer has outdated data, you shouldn't close instantly.
You should only trigger the force-close when receiving an error message from your peer.
This gives them an opportunity to correct it and potentially prevent the force-close.

See lightning/bolts#934 for details.
@Roasbeef Roasbeef added channel closing Related to the closing of channels cooperatively and uncooperatively channel management The management of the nodes channels spec labels Nov 30, 2021
@t-bast t-bast mentioned this issue Jan 9, 2023
Open
@saubyk saubyk added this to the v0.16.0 milestone Jan 11, 2023
@Roasbeef Roasbeef mentioned this issue Jan 12, 2023
Closed
7 tasks
@saubyk saubyk removed this from the v0.16.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roasbeef Roasbeef

Labels
channel closing Related to the closing of channels cooperatively and uncooperatively channel management The management of the nodes channels spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

htlcswitch: send an error before marking a channel w/ local data loss Roasbeef/lnd
3 participants
@Roasbeef @t-bast @saubyk