Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to generate a password / Custom Dictionnary #21

Open
regisdenice opened this issue Aug 23, 2024 · 3 comments
Open

Failed to generate a password / Custom Dictionnary #21

regisdenice opened this issue Aug 23, 2024 · 3 comments
Assignees

Comments

@regisdenice
Copy link

Thank you for making this plugin, I think your plugin has a great potential 🎉 🥳

Goal

Enjoy your plugin in my language 1

Action

I am building a French dictionary, and I share my 0.1 test version ReadablePassphrase - French 0_1.xml 2

Issue

The Preview tab Failed to generate a password, withe either message:

  1. The sequence contains no matching elements 3
  2. maxExlusive must be positive
    Parameter Name: maxExlusive
    The actual value was 0. 4

Note; your plugin creates password with my own dictionary 😄 👍 _

How to reproduce ?

  1. KeePass > Tools > Generate Password... > Generating using custom algorithm > Readable Passphrase Generator > Options > Use your own dictionary > ReadablePassphrase - French 0_1.xml > OK > Preview tab 3
  2. (Then from the Generating using custom algorithm window) > Options > OK > Preview tab 4

Request

In order to build (and share) my dictionary, please could you help me understand what I am missing ?

Footnotes

  1. I understand better my language than English than C# :D
    I have more trouble remembering the unknown words that might form a sentence that makes no sense but is grammatically almost correct.

  2. As I did not find a template, my dictionary is based on:
    your example: https://github.com/ligos/readablepassphrasegenerator/wiki/Make-Your-Own-Dictionary
    and your dictionaries: https://github.com/ligos/readablepassphrasegenerator/tree/master/trunk/MergePartsOfSpeech

  3. The sequence contains no matching elements
    2024 08 23 - 18 55 47 Preview Exception Often
    2024 08 23 - 18 55 03 Configuration 2

  4. maxExlusive must be positive Parameter Name: maxExlusive The actual value was 0.
    2024 08 23 - 18 55 53 Preview Exception Rarely
    2024 08 23 - 19 24 39 Configuration Reopened 2

@regisdenice
Copy link
Author

I forgot to mention that I do not have this issue when using the built-in dictionary.

@ligos ligos self-assigned this Aug 25, 2024
@ligos
Copy link
Owner

ligos commented Aug 25, 2024

Hi @regisdenice, looks like you've made a great start to a French dictionary!
I wish you well with your work 🙂

I was able to reproduce your error. It looks like its related to numbers. It appears the plugin assumes a dictionary has at least one number.

I was able to resolve the issue by adding a <numberRange> to your dictionary:
image

The only way to add numbers is via <numberRange>. That is OK for numerals (like 1, 2, 3, etc). But I'll make another issue to add <number value="one"> or <number value="un">, at some time in the future.

Let me know if this doesn't work.
Murray

@ligos
Copy link
Owner

ligos commented Aug 25, 2024

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants