Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise-creation methods with __has_feature(objc_arc_fields) #60

Open
lilyball opened this issue Aug 20, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@lilyball
Copy link
Owner

We have a few methods on TWLPromise that we expose for Obj-C++ that return std::pair or std::tuple. Starting in Xcode 10 we can expose similar methods to Obj-C because C structs are allowed to have ARC object pointers in fields. We can test for this with __has_feature(objc_arc_fields).

The new methods we add should be omitted in C++ because the existing std::pair and std::tuple methods are better there.

@lilyball lilyball added the enhancement New feature or request label Aug 20, 2020
@lilyball
Copy link
Owner Author

I'm not sure what we should call them though, we can't re-use the same selector name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant