Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message not reflective of the error #3

Open
limweijun opened this issue Nov 11, 2022 · 1 comment
Open

error message not reflective of the error #3

limweijun opened this issue Nov 11, 2022 · 1 comment

Comments

@limweijun
Copy link
Owner

limweijun commented Nov 11, 2022

image.png

As stated in the user guide it should contain which i believe is a number, hence the error should show "it should contain a number instead when i input an alphabet

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 14, 2022

Team's Response

This is a syntax error, the input specified includes a character rather than an index as mentioned in the usage. Additionally, the UG does specify that the index needs to be a positive integer.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Since your UG specify it requires a positive integer, shouldn't your error message be the same as well by saying : "a positive integer is required" rather than showing syntax error message? As it's inconsistent. And in the worst case scenario, user might not be able to enter a valid command, as it does not know that a positive integer is required.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants