Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seems to have unnecessary white space in page 21 of dg #8

Open
limweijun opened this issue Nov 11, 2022 · 1 comment
Open

seems to have unnecessary white space in page 21 of dg #8

limweijun opened this issue Nov 11, 2022 · 1 comment

Comments

@limweijun
Copy link
Owner

limweijun commented Nov 11, 2022

image.png


As seen only 5 sentences is included in page 21.

@soc-pe-bot
Copy link

soc-pe-bot commented Nov 14, 2022

Team's Response

Rejected as we feel that the alternative is worse, as it would result in different sections being on the same page as other sections, and could hinder the reader, so we added page breaks to split the sections. PDF conversion resulted in us resorting to this method, but thank you for the suggestion.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: I think a better way would let "Current Implementation" and the first diagram in your page 19/20 of DG to be on a same page, and the introduction of the 2nd diagram and description to be on a second page. Not only this will not hinder reading but user will have a clear idea that this page is talking bout this diagram, and another page is talking about another diagram.

In fact, your current implementation with the diagram at the end of the page, but with only five sentences on the next page describing the diagram might hinder user reading as user has to flip between the 2 pages to understand what it is about. E.g. when user is looking at the diagram, user has to flip to the description to understand what the diagram is saying, and when the user is reading the description, he/she has to flip to the diagram page again to understand what the description is saying.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants