Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] [DTM] Use of a single bucket #5234

Open
chibenwa opened this issue Jul 24, 2024 · 4 comments
Open

[EPIC] [DTM] Use of a single bucket #5234

chibenwa opened this issue Jul 24, 2024 · 4 comments
Labels
customer Epic multitenancy refactoring Code enhencements that don't alter software behaviour security

Comments

@chibenwa
Copy link
Member

Why?

Ideally we shall restrict Twake Mail rights to a restricted set of buckets.

How?

Instead of using the following buckets:

Screenshot from 2024-07-24 00-37-29

Use a single deleted-message-vault bucket.

Keys in there would be organized by month: 2024/07/{UUID}

We could provide a custom implementation of the DeletedMessageVault relying directly on the S3 client without relying on the BlobStore for ease of implementation if needed. Ideally we would reuse the existing Cassandra / PGSQL metadata.

This could be a Twake Mail component first.

@chibenwa chibenwa added security refactoring Code enhencements that don't alter software behaviour labels Jul 24, 2024
@chibenwa
Copy link
Member Author

linagora/tmail-flutter#3028 (comment)

CF @ducnm0711

Though this could be an important improvment, I do not foresee work on this in a short timeframe due to competing customer projects.

@chibenwa chibenwa changed the title [DTM] Use of a single bucket [EPIC] [DTM] Use of a single bucket Jul 24, 2024
@chibenwa chibenwa added the Epic label Jul 24, 2024
@chibenwa
Copy link
Member Author

While we are at it we shall study feasability of per-domain isolation strategy of deleted message vault CF #5263

@chibenwa
Copy link
Member Author

chibenwa commented Sep 2, 2024

Got bitten hard on CNB prod by this: deleted-messages-2024-09-01 bucket did not exist and TMail had no right to create it...

@ducnm0711
Copy link

Ideally we shall restrict Twake Mail rights to a restricted set of buckets

Ideally Twake Mail should create all necessary data in a single bucket. Restricting access right to a set of buckets is a feature of s3 Service Provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Epic multitenancy refactoring Code enhencements that don't alter software behaviour security
Projects
None yet
Development

No branches or pull requests

2 participants