Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Logout: I got asked permission to use "abcxyz.org" to login #3312

Open
quantranhong1999 opened this issue Nov 27, 2024 · 4 comments
Open
Assignees

Comments

@quantranhong1999
Copy link
Member

Why

When I chose to logout, I got asked to use the site "abcxyz.org" to LOGIN.

ScreenRecording_11-27-2024.16-30-41_1.MP4

That sounds weird to me. Is there anything we can do to improve the iOS permission request for logout?

Env

Twake Mail iOS 0.14.1.

@hoangdat
Copy link
Member

@dab246 , can we change the content of login to logout?

@hoangdat
Copy link
Member

  • we should change TMail to Twake Mail

@dab246
Copy link
Member

dab246 commented Nov 27, 2024

@dab246 , can we change the content of login to logout?

We cannot change the login content of this dialog to logout.

  • Because the message in the dialog above appears due to the way ASWebAuthenticationSession works when using OIDC (OpenID Connect) or OAuth 2.0. By default, the iOS system automatically displays this content based on the context of an authentication session, but the system does not distinguish clearly between login and logout because both are requests related to user sessions.
  • But we can suppress this confirmation dialog, by setting preferEphemeralSession = true in EndSessionRequest when doing logout. It is also mentioned in the flutter_appauth documentation on pub.dev. It was also mentioned by Apple at the WWDC 2019 session. See the prefersEphemeralWebBrowserSession discussion in the documentation.
Screenshot 2024-11-28 at 00 40 19 Screenshot 2024-11-28 at 00 52 07
  • we should change TMail to Twake Mail
  • We can change it by changing the value of CFBundleName in Info.plist
Screenshot 2024-11-28 at 00 55 33

@hoangdat
Copy link
Member

hoangdat commented Dec 5, 2024

  • hide system's confirm dialog when logging out
  • change bundle name of Twake Mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants