Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Antivirus feature refactoring #735

Open
5 tasks
MontaGhanmy opened this issue Nov 20, 2024 · 2 comments
Open
5 tasks

[Improvement] Antivirus feature refactoring #735

MontaGhanmy opened this issue Nov 20, 2024 · 2 comments

Comments

@MontaGhanmy
Copy link
Collaborator

MontaGhanmy commented Nov 20, 2024

For the second iteration of the antivirus feature, we need to:

  • Add antivirus (AV) status at the file version level. [TO_DISCUSS]
  • Make all numeric lists into a single export location (e.g., an enumeration for user notification statuses).
  • Validate av_status at the file service level using a boolean to determine whether to bypass/confirm an unsafe read.
  • Disable email notifications for "file too large" /"skipped" status.
  • Rename and refactor the flag used to enable the antivirus (AV) feature.
@shepilov
Copy link
Member

"Disable email notifications for "file too large" /"skipped" status." it's not just diable, we need then notification on UI to user, that we won't scan this file, and it should be don't after new upload widget that @ericlinagora is doing

@ericlinagora
Copy link
Contributor

can we get the size threshold client side ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants