Issue while trying to migrate phpBB3 to Flarum. Converter tries to call "phpbb2" class which is not found

[Stuckbert]

Hi,
First of all, thanks for your work!
i'm currently trying to migrate data from a small phpbb3 board to flarum with nitro porter.
The export seems to work so far, but when starting to convert the data, i get a PHP Fatal error as a "phpbb2" class is getting called and is not found.

Here is the command i used:
porter -p=PhpBb3 -o=Flarum -s=source -t=flarum --src-prefix=phpbb_ --tar-prefix=flarum_

Connections are properly configured within config.php (as "source" and "flarum" and working.

Here is the exception i got:

porter -p=PhpBb3 -o=Flarum -s=source -t=flarum --src-prefix=phpbb_ --tar-prefix=flarum_

Permissions are not migrated. Verify all permissions afterward.
Source: phpBB 3 (source)
Target: Flarum (flarum)
Flag: Use Discussion Body: Enabled
export: User — 102 rows, 00.33s (1.8mb)
export: Role — 8 rows, 00.13s (1.7mb)
export: UserRole — 133 rows, 00.11s (1.8mb)
export: UserNote — 0 rows, 00.06s (0b)
export: Rank — 1 rows, 00.12s (1.7mb)
export: UserMeta — 176 rows, 00.15s (1.8mb)
export: Category — 27 rows, 00.15s (1.7mb)
export: Discussion — 1342 rows, 00.87s (2.8mb)
export: Comment — 6872 rows, 03.63s (3.6mb)
export: UserDiscussion — 3020 rows, 00.59s (2.7mb)
export: Poll — 8 rows, 00.12s (2.2mb)
export: PollOption — 30 rows, 00.13s (2.2mb)
export: PollVote — 18 rows, 00.07s (2.2mb)[23-Apr-2024 16:45:35 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: call_user_func(): Argument #1 ($callback) must be a valid callback, class "Phpbb2" not found in /home/user/.config/composer/vendor/linc/nitro-porter/src/Storage.php:88
Stack trace:
#0 /home/user/.config/composer/vendor/linc/nitro-porter/src/Storage.php(88): call_user_func(Array, '.', 'RealSubject', Array)
#1 /home/user/.config/composer/vendor/linc/nitro-porter/src/Storage.php(60): Porter\Storage->filterData(Array, Array)
#2 /home/user/.config/composer/vendor/linc/nitro-porter/src/Storage/Database.php(92): Porter\Storage->normalizeRow(Array, Array, Array, Array)
#3 /home/user/.config/composer/vendor/linc/nitro-porter/src/ExportModel.php(235): Porter\Storage\Database->store('Conversation', Array, Array, Object(Porter\Database\ResultSet), Array, Object(Porter\ExportModel))
#4 /home/user/.config/composer/vendor/linc/nitro-porter/src/Source/PhpBb3.php(637): Porter\ExportModel->export('Conversation', 'select pm.*,\n  ...', Array)
#5 /home/user/.config/composer/vendor/linc/nitro-porter/src/Source/PhpBb3.php(106): Porter\Source\PhpBb3->conversations(Object(Porter\ExportModel))
#6 /home/user/.config/composer/vendor/linc/nitro-porter/src/Controller.php(29): Porter\Source\PhpBb3->run(Object(Porter\ExportModel))
#7 /home/user/.config/composer/vendor/linc/nitro-porter/src/Controller.php(118): Porter\Controller::doExport(Object(Porter\Source\PhpBb3), Object(Porter\ExportModel))
#8 /home/user/.config/composer/vendor/linc/nitro-porter/bin/porter(17): Porter\Controller::run(Object(Porter\Request))
#9 /home/user/.config/composer/vendor/bin/porter(119): include('/home/user/...')
#10 {main}
  thrown in /home/user/.config/composer/vendor/linc/nitro-porter/src/Storage.php on line 88

The class seems to be called by a filter in the /src/Sources/PhpBB3.php conversation_map:

$conversation_Map = array( 'msg_id' => 'ConversationID', 'author_id' => 'InsertUserID', 'RealSubject' => array( 'Column' => 'Subject', 'Type' => 'varchar(250)', 'Filter' => array('Phpbb2', 'EntityDecode') ) );
I simply tried editing the filter to Phpbb3, but of course got the same error with "phpbb3 class not found" afterwards ;)
Not sure what the array is really doing with the filter.

Can anyone check this up and give me a hint towards a fix?

Thanks!

[Spritetm]

Also ran into this... I have no idea what the class issue is, but I simply inlined the function that it tries to call:

//                'Filter' => array('PhpBb3', 'EntityDecode')
	           'Filter' => function ($value) {return html_entity_decode($value, ENT_QUOTES, 'UTF-8');}

[linc]

Nice workaround.

Looks like I created this bug when I introduced namespaces a bit ago.

Fix is here: 11d7eb4