Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default implementation of train_step for models #133

Open
drewoldag opened this issue Dec 7, 2024 · 0 comments
Open

Default implementation of train_step for models #133

drewoldag opened this issue Dec 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@drewoldag
Copy link
Collaborator

drewoldag commented Dec 7, 2024

The implementation of train_step is rather generic and is more or less boilerplate code that the models have to write (for both built in models and externally defined models)

We should be able to define a default train_step that can be overridden by a users model if needed.

It makes sense to include a default implementation in the @fibad_model decorator as one of the methods that is automatically added to the annotated class.

This approach also gives us a pathway to getting accuracy and loss values (using the built in metrics provided by pytorch-ignite) without requiring the user to define or calculate those. And then we can push those to TensorBoard as well.

@drewoldag drewoldag added the enhancement New feature or request label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant