Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle dependency requirements with release #469

Open
camposandro opened this issue Aug 22, 2024 · 2 comments
Open

Bundle dependency requirements with release #469

camposandro opened this issue Aug 22, 2024 · 2 comments

Comments

@camposandro
Copy link
Contributor

We might want to include in the source distribution a locked file of requirements (e.g. requirements.txt file with all the transitive dependencies that were proven to function at the time of publishing). This file is not intended for use by the common user but it is useful, e.g., when we rely on deployments on Kubernetes clusters (especially because when pods die&restart they tend to update dependencies automatically, which can cause mismatches in dependency versions).

This change was introduced for hipscat-import and could be bubbled up to the PPT.

@drewoldag
Copy link
Collaborator

Should include running the unit tests just prior to publishing to PyPI.

@drewoldag
Copy link
Collaborator

If we include the requirements.txt in the distribution, we should include clear instructions somewhere for users to see how we expect the requirements to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants