Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load pre-sorted datasets in documentation notebooks #397

Closed
wilsonbb opened this issue Mar 14, 2024 · 1 comment
Closed

Load pre-sorted datasets in documentation notebooks #397

wilsonbb opened this issue Mar 14, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@wilsonbb
Copy link
Collaborator

In our TAPE documentation notebooks, we encounter warnings when loading datasets where divisions are not set.

Screenshot 2024-03-14 at 3 01 46 PM

We can ensure that the Ensemble has divisions and avoids those warnings by using sorted=True for pre-sorted data or sort=True for unsorted data.

To avoid having to sort data in our tutorial notebooks, we can pre-sort our datasets (like s82_rrlyrae which is currently unsorted) and then use the sorted=True flag

@wilsonbb wilsonbb added the documentation Improvements or additions to documentation label Mar 14, 2024
@dougbrn
Copy link
Collaborator

dougbrn commented Mar 29, 2024

I went about this a slightly different way, by having the from_dataset function sort them as part of the ingest function. I think we can close this as a result, and with #415.

@dougbrn dougbrn closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants