Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowBackup in application tag #131

Open
giangpham96 opened this issue Oct 31, 2022 · 0 comments
Open

Remove allowBackup in application tag #131

giangpham96 opened this issue Oct 31, 2022 · 0 comments

Comments

@giangpham96
Copy link

giangpham96 commented Oct 31, 2022

Is it a security issue?

no

What did you do?

Consume Line SDK 5.4.1 to 5.8.0. They declare allowBackup as false in AndroidManifest.

What did you expect?

I believe the consumer should declare this, not the library. If an application have allow backup set to true, they need to use tools:replace tag to override the value from this library.

This is somehow acceptable.

However, if there is another library which set the flag to true, the overriding of the consumer result in an error during lint. For example, here is my stacktrace

Attribute application@allowBackup value=(false) from [com.linecorp.linesdk:linesdk:5.8.0] AndroidManifest.xml:22:9-36
        is also present at <...> AndroidManifest.xml:20:9-35 value=(true).

What happened actually?

The library has allowBackup declaration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant