Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag image formats #47

Closed
nicoburns opened this issue Dec 22, 2024 · 0 comments · Fixed by #50
Closed

Feature flag image formats #47

nicoburns opened this issue Dec 22, 2024 · 0 comments · Fixed by #50
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nicoburns
Copy link
Contributor

Currently just having vello_svg in your dependency graph means you are pulling in all of png, jpeg, gif, and webp from via the image crate. These should be feature flagged so that consumers of vello_svg who do not wish to support all of these image formats can remove these crates from their dependency trees.
@nicoburns nicoburns added enhancement New feature or request good first issue Good for newcomers labels Dec 22, 2024
@nicoburns nicoburns mentioned this issue Jan 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2025
@nicoburns
Feature flag raster image formats (#50)
0dc8473 
## Notes

- Fixes #47
- Allows support for raster images to be completely disabled as well as
flagging individual formats (allows the `image` dependency to be
disabled entirely as `image` is surprisingly large even with no formats
enabled)

---------

Signed-off-by: Nico Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature flag raster image formats linebender/vello_svg
1 participant
@nicoburns