Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install linkerd-multicluster with helm in air-gapped environment #11285

Closed
lhaussknecht opened this issue Aug 24, 2023 · 2 comments · Fixed by #11287
Closed

Unable to install linkerd-multicluster with helm in air-gapped environment #11285

lhaussknecht opened this issue Aug 24, 2023 · 2 comments · Fixed by #11287

Comments

@lhaussknecht
Copy link
Contributor

What is the issue?

In contrast to the control-plane and the viz chart, where we can supply an override for imagePullSecrets this is missing from the multicluster chart.

In an air-gapped environment it is not possible to deploy the the multicluster feature with helm.

How can it be reproduced?

Try to deploy the mutlicluster without access to cr.l5d.io or gcr.io.

Logs, error output, etc

Back-off pulling image private.registry.google_containers/pause:3.2

output of linkerd check -o short

n/a

Environment

  • Air Gapped, private AKS cluster

Possible solution

Supply imagePullSecrets in the multicluster chart's values.yaml.

Additional context

No response

Would you like to work on fixing this bug?

maybe

lhaussknecht pushed a commit to lhaussknecht/linkerd2 that referenced this issue Aug 24, 2023
lhaussknecht added a commit to lhaussknecht/linkerd2 that referenced this issue Aug 24, 2023
@lhaussknecht
Copy link
Contributor Author

I created a pull request, that adds the ability to supply ImagePullSecrets.

@lhaussknecht
Copy link
Contributor Author

@risingspiral I think the label "help wanted" is not needed anymore, since I created a PR #11287 on my own.

adleong pushed a commit that referenced this issue Oct 4, 2023
Fixes #11285

Add an imagePullSecrets value to the linkerd-multicluster and linkerd-multicluster-link charts so that imagePullSecrets can be specified for the multicluster extension.

---------

Signed-off-by: Louis Haußknecht <[email protected]>
@adleong adleong mentioned this issue Oct 4, 2023
adleong added a commit that referenced this issue Oct 4, 2023
This edge release adds additional configurability to Linkerd's viz and
multicluster extensions.

* Added a `podAnnotations` Helm value to allow adding additional annotations to
  the Linkerd-Viz Prometheus Deployment ([#11365]) (thanks @cemenson)
* Added `imagePullSecrets` Helm values to the multicluster chart so that it can
  be installed in an air-gapped environment. ([#11285]) (thanks @lhaussknecht)

[#11365]: #11365
[#11285]: #11285

Signed-off-by: Alex Leong <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
olix0r pushed a commit that referenced this issue Dec 6, 2023
Fixes #11285

Add an imagePullSecrets value to the linkerd-multicluster and linkerd-multicluster-link charts so that imagePullSecrets can be specified for the multicluster extension.

---------

Signed-off-by: Louis Haußknecht <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants