Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: viz: add option to add labels to web service #13305

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

omer2500
Copy link

@omer2500 omer2500 commented Nov 11, 2024

Problem
There is no option to add labels to the dashboard service (web) specifically
for example, the use case of service mirror the dashboard service to make it accessible in another cluster needs the label:

mirror.linkerd.io/exported: 'true'

Solution
Add option to add labels to dashboard service only

Validation
Run helm templates with couple of use cases to verify it adds new properties while not overwrite others.

I agree to the DCO for all the commits in this PR.

@omer2500
Copy link
Author

Hi,

Will be great to get feedback about this :)

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants