feat(dest): Allow destination controller to force opaque transport #13699
+53
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
commented
Feb 21, 2025
| // Opaque. | ||
| if opaquePort { | ||
| weightedAddr.ProtocolHint.Protocol = &pb.ProtocolHint_Opaque_{ | ||
| Opaque: &pb.ProtocolHint_Opaque{}, |
There was a problem hiding this comment.
This (and above for external workloads) are the meat and potatoes of this change, with the rest being config wiring.
sfleen
force-pushed
the
sfleen/endpoint-translate
branch
from
15b4644 to
331ef1e
Compare
Non-opaque meshed traffic currently flows over the original destination port, which requires the inbound proxy to do protocol detection. This adds an option to the destination controller that configures all meshed traffic to flow to the inbound proxy's inbound port. This will allow us to include more session protocol information in the future, obviating the need for inbound protocol detection. This doesn't do much in the way of testing, since the default behavior should be unchanged. When this default changes, more validation will be done on the behavior here. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/endpoint-translate
branch
from
331ef1e to
b6b560d
Compare
sfleen
added a commit
that referenced
this pull request
Feb 25, 2025
A follow up to #13699, this default-enables the config option introduced in that PR. Now, all traffic between meshed pods should flow to the proxy's inbound port. Signed-off-by: Scott Fleener <[email protected]>
olix0r
reviewed
Feb 26, 2025
Comment on lines
+35
to
+36
| forceOpaqueTransport := cmd.Bool("force-opaque-transport", false, | ||
| "Force proxies to route all outbound meshed traffic to the proxy's default inbound port") |
There was a problem hiding this comment.
We probably want to reframe this a bit as far as the external- (and especially user-) facing interface is concerned. It's not critical to address in the command line flag; though it is probably generally better for the terms to be consistent between the implementation and the helm chart...
We could frame this as an "outbound TLS mode", with values of:
- legacy-transparent -- the old behavior: transparently implement mTLS on connections
- transport-protocol -- the new behavior: use the transport protocol to route traffic
in that case, we could call this flag something like force-legacy-outbound-tls-mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-opaque meshed traffic currently flows over the original destination port, which requires the inbound proxy to do protocol detection.
This adds an option to the destination controller that configures all meshed traffic to flow to the inbound proxy's inbound port. This will allow us to include more session protocol information in the future, obviating the need for inbound protocol detection.
This doesn't do much in the way of testing, since the default behavior should be unchanged. When this default changes, more validation will be done on the behavior here.