Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore rows feature #85

Open
turbomam opened this issue Oct 14, 2022 · 3 comments
Open

Add ignore rows feature #85

turbomam opened this issue Oct 14, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@turbomam
Copy link
Contributor

I love the ignore column specification. Is there some way to ignore rows? That would help illustrate content from an upstream provider that is being excluded from the model.

Could the metatype specification be repurposed to allow for ignoring rows? (If it doesn't support that already?)

@cmungall
Copy link
Member

cmungall commented Oct 14, 2022

great idea!

metatype: this would be awkward for sheets that don't use a metatype. It might be simpler to have a column like hide_row and a value of True means the row is ignored. (unfortunately the heading ignore is taken to mean ignore the column)

what is the priority on this?

@cmungall cmungall added the good first issue Good for newcomers label Oct 14, 2022
@cmungall cmungall removed their assignment Oct 14, 2022
@turbomam
Copy link
Contributor Author

priority: would't fix anything that is truly broken, but it would help my collaborations and I would start using it right away

@jamesamcl
Copy link

I ended up patching the code to skip rows that generate errors to get something usable quickly

would like an --continue-on-error option or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants