Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark theme #49

Open
NightMean opened this issue Jan 5, 2024 · 16 comments
Open

Feature Request: Dark theme #49

NightMean opened this issue Jan 5, 2024 · 16 comments

Comments

@NightMean
Copy link

Hi, thanks for making this extension! :)

As linkwarden itself supports dark theme, it would be great addition if extension would support it as well.
What I would like is either toggle in the config or that the extension would respect the Linkwarden/System settings.

@crkos
Copy link
Member

crkos commented Jan 5, 2024

Hello thanks for the suggestion, of course, since we are using shadcn ui, This will be easy to implement, It will probably be shipped on the next update, i'm doing some automating sync when bookmarking if wanted on the options of the extension, So just wait some it will be shipped along with it!

@NightMean
Copy link
Author

Perfect, thanks a lot ! I'll happily wait :)

@crkos
Copy link
Member

crkos commented Jan 7, 2024

Dark theme was implemented!, if you wish to install right now i would advise to check "dev" branch, if not wait until the update on stores, I'm working on some updates for the extension that would resolve this, #45 and #36

@NightMean
Copy link
Author

Whoa, thanks for the quick implementation! :) Apologize for late reply, I've just tested that and it works as expect. Can't wait for the update.
Just one minor thing, the initial config screen is still white without taking in account the system dark theme. Not sure if this is how you wanted it or if it was forgotten by mistake.

image

@crkos
Copy link
Member

crkos commented Mar 17, 2024

Yeah i think that is due to those being completly different pages, so i didnt remember that while doing it, that will be solved on the next update

@arnavpraneet
Copy link

Hi, unrelated to that but I saw you mentioned right click to save in context menu in this issue, are you still working on the update/is it done already? I was trying my hand at it but I am very new to extensions and all and haven't had much luck. Thanks!

@crkos
Copy link
Member

crkos commented Apr 19, 2024

Hello, you should be able to right click on any web page and be able to add the link

@arnavpraneet
Copy link

Does this work on the latest version on Firefox or Chrome? I tried with both from the extension store, didn't work for me. Nothing in the context menu.

@crkos
Copy link
Member

crkos commented Apr 21, 2024

It should appear like this, It supported on both:
contextmenu

@arnavpraneet
Copy link

Still no dice, not working for either. Anything I can check to see what's wrong? Sorry a little new to this stuff

@crkos
Copy link
Member

crkos commented Apr 25, 2024

I dont really know what could be wrong, It is there, I mean unless someone has the same problem, I cant really know for sure what could be the problem

@crkos
Copy link
Member

crkos commented Apr 25, 2024

Well if you want send a ss of the context menu when you right click on a page.

@arnavpraneet
Copy link

Understandable, I will check it on other systems to see if its affecting my system only, and wait for if anyone has the same problem. Thanks for your time!
I will attach an SS of the context menu when I right click on a page as well.
image
image
first screenshot when right clicking on a link, second when you right click on the page without selecting any link.

@crkos
Copy link
Member

crkos commented Apr 25, 2024

If this goes on please just make a new issue, because this thread is about something else.

@daniel31x13
Copy link
Member

@arnavpraneet could you confirm if you’re on the latest version of the extension?

@arnavpraneet
Copy link

yes @daniel31x13, shall I make a new issue now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants