Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line arguments support for existing psl-examples interfaces #246

Open
eriq-augustine opened this issue Oct 30, 2019 · 2 comments
Open

Comments

@eriq-augustine
Copy link
Member

Issue by shrestabs
Sunday Mar 10, 2019 at 19:22 GMT
Originally opened as eriq-augustine#199


Currently while executing psl-examples the run.sh of all interfaces (expect CLI) does not take command line arguments as parameters for psl or logging. CLI recently supported this feature. https://github.com/linqs/psl-examples/pull/5 . This issue is to track command line arguments support for the groovy, java and python interfaces of psl-examples.

@eriq-augustine
Copy link
Member Author

Comment by eriq-augustine
Sunday Mar 10, 2019 at 19:39 GMT


More succinctly stated, we want all of our standard implementations to be able to take in command line arguments like the cli.

Note that in interfaces that are less structured that the cli (every other interface), there are two places that work must be done: the interface itself and the example/suggested usage of the interface
The interface itself refers to the package in the psl core repo (e.g. psl-groovy). The example/usage refer to the implementations in psl-examples.
It is very important that the correct line is drawn between them.

@eriq-augustine
Copy link
Member Author

Eventually, all interfaces will go through the new PSL Runtime.
So now we have a common place for options to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant