Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tacd: remove dependencies on actions-rs GitHub actions #83

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ci: tacd: remove dependencies on actions-rs GitHub actions #83

wants to merge 5 commits into from

Commits on Nov 18, 2024

  1. ci: tacd: drop rust version 1.70 from nanbield, add 1.79 from styhead 

    We no longer need to build new tacd versions on nanbield,
so we can drop the check.

We do however need to build on the new styhead yocto release,
so add a check for its rust version.

Signed-off-by: Leonard Göhrs <[email protected]>
    @hnez
    hnez committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2a6d74b View commit details
    Browse the repository at this point in the history

  2. ci: tacd: use run: rustup instead of uses: actions-rs/toolchain 

    The actions-rs GitHub actions are no longer being maintained and started
producing warnings on every run some time ago.

Since rustup comes pre-installed on the default action runner images
we can use it directly to install our toolchain.
The current stable channel rust version is also likely already installed
on the machine.

Signed-off-by: Leonard Göhrs <[email protected]>
    @hnez
    hnez committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0ce97cc View commit details
    Browse the repository at this point in the history

  3. ci: tacd: use run: cargo instead of actions-rs/cargo 

    The actions-rs GitHub actions are no longer being maintained and started
producing warnings on every run some time ago.

We can just call `cargo` ourself instead of relying on an action to do it
for us.

Signed-off-by: Leonard Göhrs <[email protected]>
    @hnez
    hnez committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9f60bf4 View commit details
    Browse the repository at this point in the history

  4. ci: tacd: use run: cargo clippy instead of actions-rs/clippy-check 

    The actions-rs GitHub actions are no longer being maintained and started
producing warnings on every run some time ago.

We can just call `cargo clippy` ourself instead of relying on an action
to do it for us.

Signed-off-by: Leonard Göhrs <[email protected]>
    @hnez
    hnez committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fdc979e View commit details
    Browse the repository at this point in the history

  5. ci: tacd: use run: cargo deny instead of EmbarkStudios/cargo-deny-action 

    Other than the actions-rs actions the cargo-deny action is actually
actively maintained, but replacing it with a simple `cargo deny` call
removes our last non-GitHub provided action dependency and makes it a bit
easier to determine what is actually happening in the action,
should one e.g. want to reproduce it locally.

Signed-off-by: Leonard Göhrs <[email protected]>
    @hnez
    hnez committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8d5da67 View commit details
    Browse the repository at this point in the history