-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readahead02.c fixes #972
Comments
Hi, Thank you |
@indumathiraju this is not really the right place to ask this question, this issue is about bugs in readahead02 test. Question like this are best to be raised on the project mailing list. |
@indumathiraju , Please check - https://github.com/linux-test-project/ltp#readme |
Looks like the patch linked by @coolgw hasn't been merged yet. I'm wondering what was missing. Is there a way to display reviews in patchwork? |
@Martchus you can check v4, v3 etc in patchwork. There has some review comments. |
I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)
Ah, so I understand that you're waiting for further feedback here. |
@Martchus Unfortunately patchwork does not connect series together, this functionality would have to be added. There is already ticket for it: getpatchwork/patchwork#506 |
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/ v5 version rejected. |
There are a couple things that should be fixed in the test:
We run the test with a loop device it will fail with ENOSPC if we pass -s bigger than the loop device, we should at least check if the device is large enough in the test setup.
The test should make use of use tst_parse_filesize() so that we can pass sizes with units e.g. -s 128M.
As we run the test inside a loop device I guess that we can also sync and drop caches just for the device, which should be faster than syncing and dropping the whole system. Possibly we just need to umount it and mount it again.
The text was updated successfully, but these errors were encountered: