fix: correct return value logic in doCopyLocalByRange #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix inverted return condition for copy operation success - Return true when NextDo is kDoCopyNext indicating successful copy - Maintain consistent success/failure state with other copy methods This change fixes a logical error where the copy success state was incorrectly inverted, ensuring proper flow control in range-based file copy operations. Log: correct return value logic in doCopyLocalByRange Bug: https://pms.uniontech.com/bug-view-290241.html
deepin pr auto review关键摘要:
是否建议立即修改:
|
GongHeng2017
approved these changes
Nov 27, 2024
max-lvs
approved these changes
Nov 28, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GongHeng2017, liyigang1, max-lvs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a logical error where the copy success state was incorrectly inverted, ensuring proper flow control in range-based file copy operations.
Log: correct return value logic in doCopyLocalByRange
Bug: https://pms.uniontech.com/bug-view-290241.html