Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [search] The background color position is incorrect #1012

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Dec 3, 2024

as title

Log: fix issue

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • searchresultitemdelegate.cpp文件中,新增的代码注释应该更详细地说明为什么需要移除前导空格,以及这样做的影响。
  • searchresultitemdelegate.cpp文件中,调整格式列表的偏移量时,应该检查offset是否为负数,以避免格式范围超出文本范围。
  • CMakeLists.txt文件中,安装目录的更改可能会导致依赖此脚本的构建系统出现问题,需要确认新的目录toolchain是否正确且包含所需文件。

是否建议立即修改:

  • 是,特别是对于searchresultitemdelegate.cpp文件中的注释和偏移量调整,这些修改应该立即进行,以确保代码的可读性和正确性。
  • 对于CMakeLists.txt文件中的更改,建议在合并到主分支之前进行彻底测试,以确保不会影响构建过程。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign deepin-mozart for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit 5430fa6 into linuxdeepin:master Dec 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants