Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteModelMixin.delete returns 200 instead of 204 #36

Open
bjd183 opened this issue Dec 4, 2017 · 1 comment
Open

DeleteModelMixin.delete returns 200 instead of 204 #36

bjd183 opened this issue Dec 4, 2017 · 1 comment

Comments

@bjd183
Copy link

bjd183 commented Dec 4, 2017

The destroy() method in the DestroyModelMixin for DRF returns HTTP_204_NO_CONTENT whereas the delete() method in DeleteModelMixin here returns 200. It seems this should be consistent and the 204 would be more correct. Am I missing something?
@linuxlewis
Copy link
Owner

Seems reasonable to me. PRs are welcome for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linuxlewis @bjd183