Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program invokes external commands #2

Open
2 tasks
jpcima opened this issue Nov 16, 2019 · 0 comments
Open
2 tasks

Program invokes external commands #2

jpcima opened this issue Nov 16, 2019 · 0 comments

Comments

@jpcima
Copy link
Member

jpcima commented Nov 16, 2019

  • ALSA MIDI

The programs mixes use of libasound API, and of external commands and /proc interface.
To clean up things, all should be converted to ALSA API.
It shouldn't require to have the command aconnect.

See src/organMIDIIn.C.

  • File copy

Don't call external cp, particularly with unquoted shell arguments.
If the home directory has special shell characters or spaces, it fails.

horgand/src/organ.C

Lines 953 to 954 in e790c4f

sprintf(orden, "cp %s/* %s", DATADIR, userdatadir);
system(orden);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant