calculator@scollins:Fix broken rpn operators/#769 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrversteegh
force-pushed
the
fix/#769
branch
from
5e81cf9
to
ca11d58
Compare
|
cc @schorschii |
rcalixte
approved these changes
Sep 28, 2023
|
@jrversteegh Thanks for this fix. |
Sorry for the confusion @schorschii. Per the README, this was a bug fix for an open Issue and one week had lapsed from when you were notified. Without any indication from you one way or another, this was merged. |
For an open issue which I wasn't notified about... Your mention was the first time I heard about it and then the time for having a look at it was simply too short. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variable declarations/"let" statements appeared to be missing. Refactored the code a bit and avoided missing "let" statements. That should fix #769