system-monitor-graph@rcassani: Fix Stuttering #938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rcassani , we noticed that
subprocess.init(null)
causes microstutters on our desktops, see #932. This PR fixes the issue like in my diskspace desklet (#937).With this change, the values are read directly from files using Gio's
load_contents_async
instead of spawninghead
orcat
subprocesses to read it.For scenarios where this is not possible (NVIDIA GPU monitoring), I switched
subprocess.wait_async
toload_contents_async
andload_contents_finish
which seems to be the correct way to read subprocess output async, as described here in the Gio docs.