Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-monitor-graph@rcassani: Fix Stuttering #938

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

schorschii
Copy link
Contributor

Hi @rcassani , we noticed that subprocess.init(null) causes microstutters on our desktops, see #932. This PR fixes the issue like in my diskspace desklet (#937).

With this change, the values are read directly from files using Gio's load_contents_async instead of spawning head or cat subprocesses to read it.

For scenarios where this is not possible (NVIDIA GPU monitoring), I switched subprocess.wait_async to load_contents_async and load_contents_finish which seems to be the correct way to read subprocess output async, as described here in the Gio docs.

@rcalixte
Copy link
Member

@rcassani This seems like a noteworthy bug fix so it would be nice to have it merged sooner than later if possible. If you would like some time to review, that's fine too.

@rcassani
Copy link
Contributor

Hi @schorschii, nice work!
It was kind of reported in #913, which is properly solved with this PR.
@rcalixte, ready to be merged

@rcalixte rcalixte merged commit d942005 into linuxmint:master Oct 26, 2023
1 check passed
@rcalixte
Copy link
Member

Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants