Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build without NLS/translations #155

Open
vishwin opened this issue Jul 4, 2022 · 3 comments
Open

Cannot build without NLS/translations #155

vishwin opened this issue Jul 4, 2022 · 3 comments

Comments

@vishwin
Copy link

vishwin commented Jul 4, 2022

After mesonbuild/meson@8b573d7, it is no longer possible to build without NLS/translations while mate-xapp-status-applet is unconditionally built since that uses i18n.merge_file() (which is not necessarily just for NLS purposes). Making mate-xapp-status-applet optional like #83 is one way to unbreak this.
@eli-schwartz
Copy link
Contributor

it is no longer possible to build without NLS/translations

Was that ever officially supported? Maybe if you want this there should be a meson_options.txt option for it.

@vishwin
Copy link
Author

vishwin commented Jul 5, 2022

Not sure, but prior to that meson commit it was possible to output such. Did mate-xapp-status-applet actually work as intended with msgfmt left out of the build environment? Who knows…

@eli-schwartz
Copy link
Contributor 

<datadir>/mate-panel/applets/org.x.MateXAppStatusApplet.mate-panel-applet

would not get created with msgfmt left out of the build environment. So the applet would not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishwin @eli-schwartz