Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] grep error in logs #75

Closed
1 task done
mitar opened this issue Jul 11, 2023 · 10 comments
Closed
1 task done

[BUG] grep error in logs #75

mitar opened this issue Jul 11, 2023 · 10 comments

Comments

@mitar
Copy link

mitar commented Jul 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I see the following warning/error in container's log:

grep: unrecognized option: ---BEGIN OPENSSH PRIVATE KEY-----
b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAABlwAAAAdzc2gtcn
NhAAAAAwEAAQAAAYEA25ttIxEySnnFFev/t0Qh30zaYQp9bDuvt/uJy5o4IOUUH5Fv0pJ7
KI9pWSp2IPM9WhCw3Dtiwk7Oey9JTTs8rfsWXvfVEFqG/vpDA0bXJtk+UNuwKvHgsp3o4l
KgjFgMI65rOxbo9BYa2kUPCndhyqqh4yrVXTU3TygJBZnY7KmAOT0Q9v35vw2Tut/8gCvW
W7lV/b1rPg3OA9YGY/djZ3PL78B9gi9SHVF79R67zzV8Hw+p1trQtihRd3tsEpp8zXpdFA
3ejs3mVob+GoJUCLk89rjFjQZwkmvRJv18BJ7gEdjlWsYEWWsPYiSKDiTx4VrvM1Ac3TPp
sq40oAQz0O5ZeCjp3cVVHI9WCbOkaSWI3YXsc4KwHBxvuccT26W9o5PPLSNK2n6SIeLeRb
k188KJowNoMmEPdnGGJbBnNN9usSYU/BZF+FAZIb7I1X1D5WesMYOQFj7uzvHHGBg3JB1h
tQ/kGmizj4UvjANl2hhAxhSeFEPdNOclVRUoXQ6LAAAFiIuKYbmLimG5AAAAB3NzaC1yc2
EAAAGBANubbSMRMkp5xRXr/7dEId9M2mEKfWw7r7f7icuaOCDlFB+Rb9KSeyiPaVkqdiDz
PVoQsNw7YsJOznsvSU07PK37Fl731RBahv76QwNG1ybZPlDbsCrx4LKd6OJSoIxYDCOuaz
sW6PQWGtpFDwp3YcqqoeMq1V01N08oCQWZ2OypgDk9EPb9+b8Nk7rf/IAr1lu5Vf29az4N
zgPWBmP3Y2dzy+/AfYIvUh1Re/Ueu881fB8Pqdba0LYoUXd7bBKafM16XRQN3o7N5laG/h
qCVAi5PPa4xY0GcJJr0Sb9fASe4BHY5VrGBFlrD2Ikig4k8eFa7zNQHN0z6bKuNKAEM9Du
WXgo6d3FVRyPVgmzpGkliN2F7HOCsBwcb7nHE9ulvaOTzy0jStp+kiHi3kW5NfPCiaMDaD
JhD3ZxhiWwZzTfbrEmFPwWRfhQGSG+yNV9Q+VnrDGDkBY+7s7xxxgYNyQdYbUP5Bpos4+F
L4wDZdoYQMYUnhRD3TTnJVUVKF0OiwAAAAMBAAEAAAGAfEHzfLYMOKux4neIV1ALwmef4O
yojwcuo/GFxFhcjfBQdJQ8K2+KlCahOzyVXouDGWT8TYCknsEsf/L/jN2Jtf+uZsngGsK+
Q6OjK0V4E5k0c1f61DHMLATBct3Bzec75yyXq/WIliOzyfDtU8S85omp0/m2hGjKBNXoVO
z6Gt7FmJ1+7eJC3+F0x3ZZTsR/I6M4jrwQ5Cm3eeAt+X5PFogkymGmInVYBxLGCqn7JoFi
28hnFxT0pz0k63BAdD5IdqFbV5mpTniwkSxiTfIJhxvtZHI6oz5zCv8Xj7pbpYssjnDhwS
4ErpOodY3cC92VIHHdIKCEAKdYu+vxx7aBhCVvHt1b5xDz2xzRTF0SIp3qrpp5or4YVO4s
QFdDP0pPxdE0qOfo7PH8LFpHBcCqGGRcAD7zRrrkAkIO7FfgGKZRV6v0LPThm7LV0bp5LH
8rNwKgjJoaVqy57ajV5MCdgEUNubBP/cVGKWSHtGEhruUCtCRFV43aI7tMTChIb9PxAAAA
wQDM9+GfZqW+wNQYHd+Vwl+faQPaCCSzyT0gTC9io5PiQ8fnMZaQhSXi91I6F2Ir7ybpex
1R5ld7SLbl4pknjJjWDu93Xm5oe5Rpoz9SYnmyOjMbdj+dRmLjXVfv19PzjvgxMVQyXXnh
710rVsTTGDi1kbX20PSUDzcMjrppLFlBvDiyIROVgUvyFGZdDCmRbEUaF5h7YaLMRroBN0
Ll3C2Du+0fT67c7YSGpujt4ZzXbRugS7X8HXmEoyj9G245cY0AAADBAP3TgUXgpyQAe1Km
rykd9fzkMBz1E91z9L3L1X48tQypPHZT7eO7+YQ6oymrqyG8KVh2aR6VAwMaUPJO6C6NVG
fusUQKj4zNdTpDYEk7hkj6j/DvMxWuwRb/QE3w+XD4J6snmbvBGSodPf8ltC+hcvr1DI2h
FqX+hnY9gzO2ur9TJVwDGT9QJUMPSHE3GV7Bpc34HwE/EWEVnEWcjSR8Q7pqyNldfu3KjK
KLaWn1cud4Z1MIaSvyWkZP+g1r6PNxXwAAAMEA3XzmCzKb3Sr0dA2uvDtZhfmNljVObeI3
8bdCGRpj+Kv9l4hx2hgLNxuUmTCNHhOV+PIEMWIi+HBhIIx946l7RosEwF6Cfg6KJ4WE/m
frGKR+pMh71UMoSQrJLNLOXNUbzZX8dax24oyl5ltUo9cP22rxki5dfmy0u/Qae9lOdLPw
3qJNCrxx6w6S8JDje5c1uK2B9GwoGnGnhHCb9U3QXS84pOxcNnsxTds2Ab1iIyNkzENpXM
Yy00UVt37pHdZVAAAAC21pdGFyQGdhZ2VhAQIDBAUGBw==
-----END OPENSSH PRIVATE KEY-----
BusyBox v1.36.1 (2023-07-06 12:28:44 UTC) multi-call binary.

Usage: grep [-HhnlLoqvsrRiwFE] [-m N] [-A|B|C N] { PATTERN | -e PATTERN... | -f FILE... } [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-R	Recurse and dereference symlinks
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file

The container does work as expected later on, there is just this warning/error in logs.

Expected Behavior

There should not be any such error/warning in logs.

Steps To Reproduce

  1. I create keys: ssh-keygen -f test/.ssh/backup_rsa -N ""
  2. I run docker run -d --name openssh -e PUID=1000 -e PGID=1000 -e SUDO_ACCESS=true -e USER_NAME=user -e PUBLIC_KEY_DIR=/ssh -p 22:2222 -v "$(pwd)/test/.ssh:/ssh" linuxserver/openssh-server:9.3_p1-r3-ls121
  3. I run docker logs openssh

Environment

- OS: Ubuntu 20.04
- How docker service was installed: `apt-get install docker.io`

CPU architecture

x86-64

Docker creation

`docker run -d --name openssh -e PUID=1000 -e PGID=1000 -e SUDO_ACCESS=true -e USER_NAME=user -e PUBLIC_KEY_DIR=/ssh -p 22:2222 -v "$(pwd)/test/.ssh:/ssh" linuxserver/openssh-server:9.3_p1-r3-ls121`

Container logs

[migrations] started
[migrations] no migrations found
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗ 
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝ 

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    1000
User GID:    1000
───────────────────────────────────────

User name is set to user
sudo is enabled without password.
ssh-keygen: generating new host keys: RSA ECDSA ED25519 
sshd is listening on port 2222
User/password ssh access is disabled.
grep: unrecognized option: ---BEGIN OPENSSH PRIVATE KEY-----
b3BlbnNzaC1rZXktdjEAAAAABG5vbmUAAAAEbm9uZQAAAAAAAAABAAABlwAAAAdzc2gtcn
NhAAAAAwEAAQAAAYEA25ttIxEySnnFFev/t0Qh30zaYQp9bDuvt/uJy5o4IOUUH5Fv0pJ7
KI9pWSp2IPM9WhCw3Dtiwk7Oey9JTTs8rfsWXvfVEFqG/vpDA0bXJtk+UNuwKvHgsp3o4l
KgjFgMI65rOxbo9BYa2kUPCndhyqqh4yrVXTU3TygJBZnY7KmAOT0Q9v35vw2Tut/8gCvW
W7lV/b1rPg3OA9YGY/djZ3PL78B9gi9SHVF79R67zzV8Hw+p1trQtihRd3tsEpp8zXpdFA
3ejs3mVob+GoJUCLk89rjFjQZwkmvRJv18BJ7gEdjlWsYEWWsPYiSKDiTx4VrvM1Ac3TPp
sq40oAQz0O5ZeCjp3cVVHI9WCbOkaSWI3YXsc4KwHBxvuccT26W9o5PPLSNK2n6SIeLeRb
k188KJowNoMmEPdnGGJbBnNN9usSYU/BZF+FAZIb7I1X1D5WesMYOQFj7uzvHHGBg3JB1h
tQ/kGmizj4UvjANl2hhAxhSeFEPdNOclVRUoXQ6LAAAFiIuKYbmLimG5AAAAB3NzaC1yc2
EAAAGBANubbSMRMkp5xRXr/7dEId9M2mEKfWw7r7f7icuaOCDlFB+Rb9KSeyiPaVkqdiDz
PVoQsNw7YsJOznsvSU07PK37Fl731RBahv76QwNG1ybZPlDbsCrx4LKd6OJSoIxYDCOuaz
sW6PQWGtpFDwp3YcqqoeMq1V01N08oCQWZ2OypgDk9EPb9+b8Nk7rf/IAr1lu5Vf29az4N
zgPWBmP3Y2dzy+/AfYIvUh1Re/Ueu881fB8Pqdba0LYoUXd7bBKafM16XRQN3o7N5laG/h
qCVAi5PPa4xY0GcJJr0Sb9fASe4BHY5VrGBFlrD2Ikig4k8eFa7zNQHN0z6bKuNKAEM9Du
WXgo6d3FVRyPVgmzpGkliN2F7HOCsBwcb7nHE9ulvaOTzy0jStp+kiHi3kW5NfPCiaMDaD
JhD3ZxhiWwZzTfbrEmFPwWRfhQGSG+yNV9Q+VnrDGDkBY+7s7xxxgYNyQdYbUP5Bpos4+F
L4wDZdoYQMYUnhRD3TTnJVUVKF0OiwAAAAMBAAEAAAGAfEHzfLYMOKux4neIV1ALwmef4O
yojwcuo/GFxFhcjfBQdJQ8K2+KlCahOzyVXouDGWT8TYCknsEsf/L/jN2Jtf+uZsngGsK+
Q6OjK0V4E5k0c1f61DHMLATBct3Bzec75yyXq/WIliOzyfDtU8S85omp0/m2hGjKBNXoVO
z6Gt7FmJ1+7eJC3+F0x3ZZTsR/I6M4jrwQ5Cm3eeAt+X5PFogkymGmInVYBxLGCqn7JoFi
28hnFxT0pz0k63BAdD5IdqFbV5mpTniwkSxiTfIJhxvtZHI6oz5zCv8Xj7pbpYssjnDhwS
4ErpOodY3cC92VIHHdIKCEAKdYu+vxx7aBhCVvHt1b5xDz2xzRTF0SIp3qrpp5or4YVO4s
QFdDP0pPxdE0qOfo7PH8LFpHBcCqGGRcAD7zRrrkAkIO7FfgGKZRV6v0LPThm7LV0bp5LH
8rNwKgjJoaVqy57ajV5MCdgEUNubBP/cVGKWSHtGEhruUCtCRFV43aI7tMTChIb9PxAAAA
wQDM9+GfZqW+wNQYHd+Vwl+faQPaCCSzyT0gTC9io5PiQ8fnMZaQhSXi91I6F2Ir7ybpex
1R5ld7SLbl4pknjJjWDu93Xm5oe5Rpoz9SYnmyOjMbdj+dRmLjXVfv19PzjvgxMVQyXXnh
710rVsTTGDi1kbX20PSUDzcMjrppLFlBvDiyIROVgUvyFGZdDCmRbEUaF5h7YaLMRroBN0
Ll3C2Du+0fT67c7YSGpujt4ZzXbRugS7X8HXmEoyj9G245cY0AAADBAP3TgUXgpyQAe1Km
rykd9fzkMBz1E91z9L3L1X48tQypPHZT7eO7+YQ6oymrqyG8KVh2aR6VAwMaUPJO6C6NVG
fusUQKj4zNdTpDYEk7hkj6j/DvMxWuwRb/QE3w+XD4J6snmbvBGSodPf8ltC+hcvr1DI2h
FqX+hnY9gzO2ur9TJVwDGT9QJUMPSHE3GV7Bpc34HwE/EWEVnEWcjSR8Q7pqyNldfu3KjK
KLaWn1cud4Z1MIaSvyWkZP+g1r6PNxXwAAAMEA3XzmCzKb3Sr0dA2uvDtZhfmNljVObeI3
8bdCGRpj+Kv9l4hx2hgLNxuUmTCNHhOV+PIEMWIi+HBhIIx946l7RosEwF6Cfg6KJ4WE/m
frGKR+pMh71UMoSQrJLNLOXNUbzZX8dax24oyl5ltUo9cP22rxki5dfmy0u/Qae9lOdLPw
3qJNCrxx6w6S8JDje5c1uK2B9GwoGnGnhHCb9U3QXS84pOxcNnsxTds2Ab1iIyNkzENpXM
Yy00UVt37pHdZVAAAAC21pdGFyQGdhZ2VhAQIDBAUGBw==
-----END OPENSSH PRIVATE KEY-----
BusyBox v1.36.1 (2023-07-06 12:28:44 UTC) multi-call binary.

Usage: grep [-HhnlLoqvsrRiwFE] [-m N] [-A|B|C N] { PATTERN | -e PATTERN... | -f FILE... } [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-R	Recurse and dereference symlinks
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file
Public key from file '/ssh/backup_rsa' added
Public key from file '/ssh/backup_rsa.pub' added
[custom-init] No custom files found, skipping...
[ls.io-init] done.
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented Jul 11, 2023

That folder needs to contain only the public keys, not private

@mitar
Copy link
Author

mitar commented Jul 11, 2023

Suureee. :-) But the error should be better, no? :-)

@mitar
Copy link
Author

mitar commented Jul 11, 2023

Ideally, private keys should just be ignored. It is much easier then to use this inside CI.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@mitar
Copy link
Author

mitar commented Aug 11, 2023

Still relevant?

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@mitar
Copy link
Author

mitar commented Sep 11, 2023

So should the error message be better?

@drizuid
Copy link
Member

drizuid commented Sep 12, 2023

We welcome PRs!

@drizuid
Copy link
Member

drizuid commented Oct 11, 2023

The readme explicitly states what is allowed in the folder indicating that user's encountering this simply did not follow the readme. While we would certainly entertain a PR improving the error handling, the OP did not choose to provide one. Closing this

@drizuid drizuid closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants