Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add parameter to set host IP #6

Closed
1 task done
Ali-Flt opened this issue Aug 21, 2023 · 5 comments
Closed
1 task done

[FEAT] Add parameter to set host IP #6

Ali-Flt opened this issue Aug 21, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Ali-Flt
Copy link

Ali-Flt commented Aug 21, 2023

Is this a new feature request?

  • I have searched the existing issues

Wanted change

A parameter being added to set the host IP address.

Reason for change

One may want the server to be on localhost instead of 0.0.0.0

Proposed code change

No response

@Ali-Flt Ali-Flt added the enhancement New feature or request label Aug 21, 2023
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented Aug 21, 2023

Please elaborate and keep the xy problem in mind https://xyproblem.info/

@Ali-Flt
Copy link
Author

Ali-Flt commented Aug 21, 2023

Right now it is possible to change the HTTP and HTTPS port of the service (default is 3000 and 3001).
But I couldn't find an option to change the bind IP address of the service. I think it runs the service on 0.0.0.0 (all network interfaces). A parameter to choose the network interface could be very useful.
This way I can run the VScodium service on 127.0.0.1:3000 instead of 0.0.0.0:3000

@aptalca
Copy link
Member

aptalca commented Aug 21, 2023

Why?

In a docker bridge network, you map the container port to whatever host port you want. You don't need to change the container ports.

You can also map 127.0.0.1:3000:3000 so on the host it only listens at that IP

@Ali-Flt
Copy link
Author

Ali-Flt commented Aug 21, 2023

You are right, I was confused for a sec I forgot I'm publishing the ports from the container to host instead of running the service directly on the host. Closing this.

@Ali-Flt Ali-Flt closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants