Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: larger FieldLabel font sizes #222

Open
GoogleCodeExporter opened this issue Feb 20, 2016 · 2 comments
Open

Feature: larger FieldLabel font sizes #222

GoogleCodeExporter opened this issue Feb 20, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Support larger text on FieldLabels for individual blocks.

Original issue reported on code.google.com by [email protected] on 23 Apr 2014 at 6:03

@GoogleCodeExporter
Copy link
Author

I did a bit of looking in to this, and may pick it up again soon.

My initial thoughts on an approach:

1. Allow for additional CSS classes to be passed in to FieldLabels during 
construction to set the text size. (Another option might be to create a new 
StyledFieldLabel class, or a setter which triggers a size recalculation)
2. Make the size_.height determined on render_(), same as size._width
3. Alter some of the usages of Blockly.BlockSvg.TITLE_HEIGHT in block_svg.js to 
account for the dynamically determined height

Attached is an example of the layout issue step #3 would need to address.

A different approach to #3 would be to change the text to use 
dominant-baseline: hanging, which would have the text anchored at the top-left 
rather than bottom-left, perhaps not requiring as much change to the svg 
rendering logic. But I'll be targeting IE9 as well which does not support this 
property.

Original comment by [email protected] on 23 Apr 2014 at 6:06

Attachments:

@GoogleCodeExporter
Copy link
Author

Feel free to make me owner and mark this as an enhancement (I don't think I 
have permissions).

Original comment by [email protected] on 24 Apr 2014 at 5:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant