Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Report: Modals with form do not have error handling #1346

Closed
khamui opened this issue Feb 6, 2023 · 2 comments
Closed

Comment Report: Modals with form do not have error handling #1346

khamui opened this issue Feb 6, 2023 · 2 comments
Assignees
Labels
Type: Enhancement small improvements to site - less then half story point
Milestone

Comments

@khamui
Copy link
Contributor

khamui commented Feb 6, 2023

URL:
user:
expected behaviour: Modals with form should show validation errors
behaviour: Modals with form do not have any validation errors
important screensize:
device & browser:
Comment/Question:
This error was mentioned here: #1338 (comment)

As the Report Modal inherits the base Modal, it misses validation errors as well. See related issue here:
#1149

@philli-m philli-m added this to the Comments milestone Sep 21, 2023
@philli-m philli-m changed the title Modals with form do not have error handling Comment Report: Modals with form do not have error handling Sep 21, 2023
@t-j-q
Copy link

t-j-q commented Jul 17, 2024

Modals with forms (report) have a character limit but its not displayed and no error message when trying to send. Maybe make send button inactive when form is empty?

@t-j-q t-j-q added the Type: Enhancement small improvements to site - less then half story point label Jul 17, 2024
@CarolingerSeilchenspringer

@TeaJayyy @mcastro-lqd Will close this issue as we have a design task for this and the design is currently in coordination with client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement small improvements to site - less then half story point
Projects
None yet
Development

No branches or pull requests

5 participants