Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAM controllers for Networks and IPs resources #1992

Merged
merged 1 commit into from
Sep 18, 2023
Merged

IPAM controllers for Networks and IPs resources #1992

merged 1 commit into from
Sep 18, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 8, 2023 •
edited
Loading

Description

This PR adds the new IPAM API with the new Networks and IPs resources and their controllers.

Ref #1990

How Has This Been Tested?

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title Frt/ipam IPAM controllers for Networks and IPs resources Sep 8, 2023
@fra98
Copy link
Member Author

fra98 commented Sep 11, 2023

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Sep 11, 2023
@fra98 fra98 marked this pull request as ready for review September 12, 2023 09:18
@fra98 fra98 requested review from aleoli and cheina97 September 12, 2023 09:18
aleoli
aleoli reviewed Sep 12, 2023
View reviewed changes
apis/ipam/v1alpha1/groupversion_info.go Outdated Show resolved Hide resolved
cmd/liqo-controller-manager/main.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/network-controller/network_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/network-controller/network_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/webhooks/ip/ip.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/webhooks/network/nw.go Show resolved Hide resolved
pkg/liqonet/ipam/ipam.proto Show resolved Hide resolved
@fra98 fra98 requested a review from aleoli September 15, 2023 07:14
cheina97
cheina97 approved these changes Sep 15, 2023
View reviewed changes
apis/ipam/v1alpha1/ip_types.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Outdated Show resolved Hide resolved
pkg/liqo-controller-manager/ip-controller/ip_controller.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/ipam branch 3 times, most recently from 756680f to 00a7c49 Compare September 18, 2023 09:20
@cheina97 cheina97 merged commit e27a5ec into liqotech:network-general Sep 18, 2023
@fra98 fra98 added kind/feature and removed hold Prevent bot merging labels Sep 18, 2023
@fra98
Copy link
Member Author

fra98 commented Sep 19, 2023

/build

1 similar comment
@cheina97
Copy link
Member

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

@aleoli aleoli Awaiting requested review from aleoli

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fra98 @adamjensenbot @cheina97 @aleoli