Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration Controller #2031

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Configuration Controller #2031

merged 1 commit into from
Sep 29, 2023

Conversation

cheina97
Copy link
Member

Description

This PR adds a new controller to manage network configuration

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from 7c8193a to c0c3d92 Compare September 19, 2023 15:54
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 4 times, most recently from 2d126dd to b962d21 Compare September 20, 2023 11:00
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 4 times, most recently from 548079e to e951f8c Compare September 20, 2023 17:12
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 3 times, most recently from f50d478 to 2f4f5f3 Compare September 21, 2023 13:44
@cheina97 cheina97 force-pushed the network-external branch 3 times, most recently from 0b3f082 to 5a75336 Compare September 21, 2023 14:05
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 2 times, most recently from 37e3305 to 6c34266 Compare September 21, 2023 14:34
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 3 times, most recently from f72ad48 to 8200e3b Compare September 21, 2023 15:11
@cheina97 cheina97 force-pushed the network-external branch 2 times, most recently from a5148fb to afe2f47 Compare September 22, 2023 14:40
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from 8200e3b to 9df0c13 Compare September 22, 2023 14:44
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 2 times, most recently from 28edf58 to c900235 Compare September 25, 2023 15:09
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from c900235 to e7b5411 Compare September 25, 2023 15:17
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from e7b5411 to 0e753ed Compare September 26, 2023 08:46
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from 0e753ed to ce4194d Compare September 26, 2023 09:38
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 marked this pull request as draft September 27, 2023 07:36
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 2 times, most recently from 34c7117 to 5e32463 Compare September 27, 2023 12:48
@cheina97 cheina97 marked this pull request as ready for review September 28, 2023 13:04
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 3 times, most recently from f6246a3 to 7236a18 Compare September 29, 2023 15:30
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/configurationcontroller branch 2 times, most recently from d69735f to 22f8676 Compare September 29, 2023 16:45
@cheina97 cheina97 force-pushed the frc/configurationcontroller branch from f1c59c0 to 0b99353 Compare September 29, 2023 16:45
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 29, 2023
@adamjensenbot adamjensenbot merged commit 34f8c0e into liqotech:network-external Sep 29, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 29, 2023
@cheina97 cheina97 deleted the frc/configurationcontroller branch October 2, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli