Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always reflect kube-root-ca.crt configmap in offloaded namespaces #2044

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Always reflect kube-root-ca.crt configmap in offloaded namespaces #2044

merged 1 commit into from
Sep 29, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 22, 2023 •
edited
Loading

Description

This PR modifies the kubelet to always reflect the kube-root-ca.crt ConfigMap in offloaded namespaces.
The ConfigMap must always be reflected for the offloaded pods to work, even if using a restricting policy as the AllowList .

How Has This Been Tested?

  • locally
  • e2e tests
  • unit tests

@fra98 fra98 added the kind/bug label Sep 22, 2023
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/confmap-kuberoot-fix branch 2 times, most recently from 4141db5 to 3161dcc Compare September 25, 2023 15:02
@fra98 fra98 marked this pull request as ready for review September 25, 2023 15:05
@fra98 fra98 force-pushed the frt/confmap-kuberoot-fix branch from 3161dcc to d4463b7 Compare September 25, 2023 15:16
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 25, 2023
@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/test

@fra98 fra98 requested review from aleoli and cheina97 September 26, 2023 07:16
@fra98
Copy link
Member Author

fra98 commented Sep 29, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/confmap-kuberoot-fix branch from d4463b7 to 01077a2 Compare September 29, 2023 07:17
@fra98
Copy link
Member Author

fra98 commented Sep 29, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 29, 2023
@adamjensenbot adamjensenbot merged commit a699475 into liqotech:master Sep 29, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 29, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli